fix(compact): close vlog after the compaction at L0 has completed #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
force-pushed
the
naman/fix-compact-l0
branch
from
de2cb19 to
4e46674
Compare
ahsanbarkati
approved these changes
Sep 28, 2021
NamanJain8
added a commit
that referenced
this pull request
Oct 5, 2021
) Vlog needs to stay open while the compaction is being run. With the CompactL0OnClose option, it becomes necessary to close the vlog after all the compactions have been completed. (cherry picked from commit cba20b9)
mangalaman93
pushed a commit
that referenced
this pull request
Feb 14, 2023
) Vlog needs to stay open while the compaction is being run. With the CompactL0OnClose option, it becomes necessary to close the vlog after all the compactions have been completed. (cherry picked from commit cba20b9)
skrdgraph
pushed a commit
to dgraph-io/dgraph
that referenced
this pull request
Mar 7, 2023
Update Badger from `7677fcb` to `6ed45ae` (on main-deprecated branch). This fixes dgraph-io/badger#1752 and dgraph-io/badger#1756. First CI failed [here](https://github.com/dgraph-io/dgraph/actions/runs/4208376321/jobs/7304322951). This issue was resolved by bumping up the Go version used in the container.
fredcarle
pushed a commit
to fredcarle/badger
that referenced
this pull request
Aug 1, 2023
…raph-io#1752) Vlog needs to stay open while the compaction is being run. With the CompactL0OnClose option, it becomes necessary to close the vlog after all the compactions have been completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vlog needs to stay open while the compaction is being run. With the
CompactL0OnCloseoption, it becomes necessary to close the vlog after all the compactions have been completed.Resolves https://discuss.dgraph.io/t/badger-v3-updatediscardstats-unexpected-fault-address/15674
This change is