Fix inheritance of custom path segmenter #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XANi
force-pushed
the
fix-custom-path-segmenter
branch
2 times, most recently
from
b291a11
to
365cd8a
Compare
dghubble
reviewed
May 5, 2021
segmenter_test.go
Outdated
| @@ -72,3 +73,62 @@ func TestPathSegmenterEdgeCases(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| type testDepth struct { | |||
There was a problem hiding this comment.
This type and the arm field don't seem to really be needed. Your example dot segmenter could just be a plain function.
segmenter_test.go
Outdated
| }) | ||
| } | ||
| for k, ok := range depthTest.cases { | ||
| t.Run("walk "+k, func(t *testing.T) { |
There was a problem hiding this comment.
t.Run shouldn't be needed I don't think. Just loop and find any false values.
segmenter_test.go
Outdated
|
|
||
| func TestCustomPathSegmenter(t *testing.T) { | ||
| depthTest := testDepth{ | ||
| cases: map[string]bool{ |
There was a problem hiding this comment.
I'd comment this // key -> visited and move it to be after the tie is created to be more clear
XANi
force-pushed
the
fix-custom-path-segmenter
branch
from
365cd8a
to
40e58ab
Compare
|
Should be fixed now, it was mostly leftovers of other way I tried to test it and forgot to cleanup. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently children nodes of path segmenter will always use default segmenter regardless of settings.
First commit tests for the problem, second commits adds function that creates new PathTrie with inherited settings