Skip to content

Conversation

@gawen
Copy link

@gawen gawen commented Oct 25, 2024

What changed?

⚠️ This PR will break retro-compatibility. I don't know if it is acceptable and will leave it to the appreciation of the reviewer.

  1. Config.RequestToken() and Config.AccessToken() now requires a context.Context
  2. Deprecates io/ioutil and replaces by io

@dghubble
Copy link
Owner

Swapping out io/ioutil yes, changing the signatures probably no.

@gawen
Copy link
Author

gawen commented Oct 28, 2024

💭 Let's provide RequestTokenWithContext and AccessTokenWithContext?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants