-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow sharing for tensorflow and theano as numpy backends #58
Conversation
|
||
.. math:: | ||
|
||
M_{pqrs} = C_{pi} C_{qj} I_{ijkl} C_{rk} C_{sl} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this has crept in as a small docs change. Can remove if necessary @dgasmith.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think the doc change is a good one and we have mathjax setup already.
@fritzo Any comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Do you want to add tensorflow
and theano
to the sharing test?
Yes that would have been nice but I've ended up adding them to
I didn't think too hard about unifying the tests but it is probably possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable, I think the tests are fine separated. Mostly the test_sharing.py
tests ensure that the cache mechanism actually works, so it sounds reasonable to combine (1) heavy tests for a few backends + (2) smoke tests for the rest.
Description
Allows sharing to be used with tensorflow and theano as numpy backends. Closes #50. The
to_{backend}
functions are all called internally within their respective{backend.py}
submodules so I didn't try and factorize out a newto_backend
function. I think it will be pretty easy (and rare) to add new conversion backends anyway. Also the tests are intest_backends.py
rather thantest_sharing.py
just because the tensorflow tests require asession
, and the theano tests can't useeinsum
itself.Status