Make JAX backend import lazy. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed the following surprising behavior: importing tensorflow also imports jax, if installed. This happens because tensorflow has an opt_einsum dependency that is imported eagerly, and the opt_einsum jax backend eagerly imports jax. To avoid this, make the jax import from opt_einsum lazy.
|
It looks like all CI builds are failing for reasons related to Conda, not the PR. |
dgasmith
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Looks like we missed this, thanks for the quick fix. I will look at pushing out a patch release today.
For the CI can you change curl -s to wget -qO- in devtools/travis-ci/before_install.sh:17? It looks like conda changed their download location without CNAME forwarding and curl doesn't follow the redirect.
|
The CI failure may be enough impetus to switch the repo over to GH actions. |
|
Done. The CI builds passed. A new release would be welcome, thanks! |
|
Thanks for the CI fix, I pull put out a patch momentarily. |
|
Release is up, conda may take a bit to build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed the following surprising behavior: importing tensorflow also imports jax, if installed. This happens because tensorflow has an opt_einsum dependency that is imported eagerly, and the opt_einsum jax backend eagerly imports jax. To avoid this, make the jax import from opt_einsum lazy.
Status