Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDefinedBy not being properly recognized for data property #588

Closed
inaja opened this issue May 9, 2023 · 3 comments
Closed

isDefinedBy not being properly recognized for data property #588

inaja opened this issue May 9, 2023 · 3 comments
Assignees
Labels
bug pressing Will fix issue in next release
Milestone

Comments

@inaja
Copy link

inaja commented May 9, 2023

In the PECO ontology (https://w3id.org/peco)
The data property http://qudt.org/schema/qudt/value has rdfs:isDefinedBy "https://qudt.org/schema/qudt/". But the generated widco file shows: is defined by https://w3id.org/peco#

image

@dgarijo
Copy link
Owner

dgarijo commented May 9, 2023

Duplicate with #587

@dgarijo dgarijo added the bug label May 9, 2023
@dgarijo dgarijo added this to the v1.4.xx milestone May 9, 2023
@dgarijo dgarijo self-assigned this Aug 10, 2023
@dgarijo dgarijo added the pressing Will fix issue in next release label Aug 10, 2023
@dgarijo
Copy link
Owner

dgarijo commented Aug 27, 2023

This only happens when rdfs:isDefinedBy points to a literal. According to https://www.w3.org/TR/rdf12-schema/#ch_isdefinedby, the range of isDefinedBy should be a rdfs:Resource. In this case, the ontology annotation is wrong

@dgarijo
Copy link
Owner

dgarijo commented Aug 27, 2023

I added a fix so if the value is not a resource, then do not complete with the ontology name by default

dgarijo added a commit that referenced this issue Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pressing Will fix issue in next release
Projects
None yet
Development

No branches or pull requests

2 participants