Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hey I made a fork and fixed a lot of bugs, and I have a question. #29

Open
time-killer-games opened this issue Aug 25, 2022 · 4 comments

Comments

@time-killer-games
Copy link

time-killer-games commented Aug 25, 2022

I was wondering if you'd like to help maintain my fork with me, which takes a bit of a different direction from the original software, because it relies specifically on SDL2 and OpenGL on Windows and Linux, with added BSD and Illumos support, and uses SDL2 Renderer on MacOS since OpenGL is deprecated on that platform. The reason I am using SDL2 is to mask the fact it uses Dear ImGui and uses a custom theme as well as makes it run in its own a floating window, without being embedded in an existing window. It also relies on my filesystem API, and ghc::filesystem so it can be built with versions of C++ besides C++17 like C++11, C++14, and C++20. I also added full localization and UTF-8 font loading support. It can be used as a CLI and as a client library. Many other things I did to improve it, and I did in my own fork instead of making a pull request to save time that it takes to be accepted in code review. I intend to add support for loading system icons for different file types like can be done on Windows for all other platforms I support. Let me know what you think, here's my fork: https://github.com/time-killer-games/libfiledialogs

@time-killer-games
Copy link
Author

time-killer-games commented Sep 8, 2022

Just an update, I added support for changing the icon theme to what the target platform uses by default. Here's a preview:

filedialogs

Repository owner deleted a comment from UnrealKaraulov Sep 12, 2022
@Mori-TM
Copy link

Mori-TM commented Feb 24, 2023

Thank you for createing this improved version, I tought I would need to do all this by myself. I have implemented this in my vulkan game engine, but there is one thing I hope you will add later and that is multi file selection.

@time-killer-games
Copy link
Author

time-killer-games commented Feb 24, 2023

The function get_open_filenames() is the function you are looking for. The one which is filenames (plural) in the function name and not singular. The return value uses a line feed \n as the delimiter. :)

https://github.com/time-killer-games/libfiledialogs/blob/22a777fc91890fa4e5ca0533d36163f96878cf5d/filedialogs/filedialogs.h#L35

@Mori-TM
Copy link

Mori-TM commented Feb 25, 2023

Oh thanks, I didn't see that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants