add access to new dust3 parameter and xrb contribution. #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
LGTM - your call whether or not we should add a test! |
Collaborator
Author
|
added a test for dust3. The test for xrb would be slow and I think it's a more specialized use case, so I'm omitting. I think we should do a new release when the tests are green and this is merged. There's some other bells and whistles I'm looking at but those can wait for a later release. |
Owner
|
Let me poke at the windows builds and see if I can fix them this afternoon/weekend and then do a release early next week? |
Collaborator
Author
|
Sounds great, thanks @dfm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding access to some new parameters.