Skip to content

Conversation

@github-actions
Copy link
Contributor

Automatically updating the FSPS submodule

Maintainers should close and then re-open this PR to get the tests to run.

@dfm dfm closed this Apr 17, 2023
@dfm dfm reopened this Apr 17, 2023
@bd-j
Copy link
Collaborator

bd-j commented Apr 24, 2023

There's some changes probably coming in tomorrow. I'll force the update workflow and handle some new hooks.

@bd-j bd-j closed this Apr 27, 2023
@bd-j bd-j reopened this Apr 27, 2023
@dfm
Copy link
Owner

dfm commented Apr 27, 2023

Somehow your commit reverted the submodule update...

@bd-j
Copy link
Collaborator

bd-j commented Apr 27, 2023

Thanks, I guess I missed a submodule update. I'll rerun the workflow and try again.

@dfm dfm closed this Apr 27, 2023
@dfm dfm reopened this Apr 27, 2023
@dfm
Copy link
Owner

dfm commented Apr 27, 2023

I'm not sure why those Windows builds are failing, but I'll take a look ASAP!

@dfm
Copy link
Owner

dfm commented Apr 27, 2023

For now I've just disabled the Windows release builds for now and I'll open an issue to remember to re-implement them in the future. I think we should just merge this whenever the tests are green.

@bd-j
Copy link
Collaborator

bd-j commented Apr 27, 2023

Sounds good, thanks @dfm. I'm going to add hooks to the new variables once this is merged.

@dfm dfm merged commit d6f575f into main Apr 27, 2023
@dfm dfm deleted the update-fsps branch April 27, 2023 17:28
@bd-j
Copy link
Collaborator

bd-j commented Apr 27, 2023

thanks!

@dfm dfm mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants