Skip to content

Less hacky check for raises #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfm merged 1 commit into from
Aug 16, 2022
Merged

Less hacky check for raises #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,8 @@ def test_param_checks(pop_and_params):
pop.params["imf_type"] = 8
# fix the invalid IMF but leave the invalid sf_start > tage
pop.params["imf_type"] = 1
try:
# This *should* still raise an AssertionError
with pytest.raises(AssertionError):
w, s = pop.get_spectrum(tage=pop.params["tage"])
# Hacky way to make sure the AssertionError still got thrown
raise ValueError("Did not throw exception for invalid sf_start > tage")
except(AssertionError):
pass
pop.params["tage"] = 1.0
pop.params["sf_start"] = 0.1
w, s = pop.get_spectrum(tage=pop.params["tage"])
Expand Down