Skip to content

Commit

Permalink
Restore compatibility with macOS 10.14 (Mudlet#4793)
Browse files Browse the repository at this point in the history
* Set XCode to 11.3 which is what we used in Travis

* Set CMAKE_OSX_DEPLOYMENT_TARGET correctly

* Correct CMakeLists

* Fix syntax

* Up to latest available XCode
  • Loading branch information
vadi2 authored Feb 17, 2021
1 parent c56bf45 commit 11ef641
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/build-mudlet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ jobs:
echo "LUA_PATH=$LUA_PATH" >> $GITHUB_ENV
echo "LUA_CPATH=$LUA_CPATH" >> $GITHUB_ENV
# Use latest available XCode
echo "DEVELOPER_DIR=/Applications/Xcode_12.4.app/Contents/Developer" >> $GITHUB_ENV
- name: (Linux) Install non-vcpkg dependencies
if: runner.os == 'Linux'
run: |
Expand Down
5 changes: 1 addition & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@
cmake_minimum_required(VERSION 3.3)

if(APPLE)
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.13") # Qt 5.11.2 with which we build on OS
# X supports 10.11 and up, but some
# tools are not provided as bottles
# for that anymore.
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.14" CACHE STRING "")
endif()

project(mudlet)
Expand Down

0 comments on commit 11ef641

Please sign in to comment.