Skip to content

Api v2 paginated global tasks #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 235 commits into
base: develop
Choose a base branch
from
Open

Api v2 paginated global tasks #981

wants to merge 235 commits into from

Conversation

@c8y3
Copy link
Contributor

@c8y3 c8y3 commented Nov 21, 2025 •
edited
Loading

Implementation of GET /api/v2/global-tasks

  • Deprecated GET /global/tasks/list
  • Cleaned code to get the related alerts
  • Moved some import of iris_current_user out of the persistence layer up into the API layer
  • Extended constraint of lint-imports: Do not import API layer from the persistence layer (iris_user)
  • Added ruff rules E211, E221, E226 and E272

This PR goes with the accompanying documentation PR#100

Elise17 added 30 commits October 8, 2025 14:04
@Elise17
Started implementation of POST /api/v2/alerts-filters
9a33abf
@Elise17
Fixed analysis check
b7088fd
@Elise17
Added function _load
103ed2c
@Elise17
Deprecated endpoint POST /filters/add in favor of POST /api/v2/alerts…
82bfec6 
…-filters
@Elise17
Added test create alert when filter data is missing
5b1290e
@Elise17
Added test test_create_alert_filter_should_return_filter_type
ea45b99
@Elise17
Added test_create_alert_filter_should_return_filter_name
4c5ddd6
@Elise17
Added test_create_alert_filter_should_return_in_filter_data_alert_title
0a0f63d
@Elise17
Started implementation of GET /api/v2/alerts-filters/{identifier}
af0bf2b
@Elise17
Fixed check analysis
0c911fe
@Elise17
Fixed importation problem
8559ad7
@Elise17
Fixed static analysis
7440b09
@Elise17
Removed user in test
0690eb0
@Elise17
Added test_get_alert_filter_should_return_filter_name
1129b73
@Elise17
Deprecated endpoint GET /filters/{identifier}
97a89e5
@Elise17
Added test_get_alert_filter_should_return_404
622b46a
@Elise17
Added test_get_alert_filter_should_return_404_when_user_has_not_creat…
9a1fffd 
…ed_alert_filter
@Elise17
Fixed static analysis
e4b4998
@Elise17
Started implementation of PUT /api/v2/alerts-filters/{identifier}
69e38c8
@Elise17
Fixed static analysis
ec809ef
@Elise17
Added test_update_alert_filter_should_return_filter_name
f438d3b
@Elise17
Added test_update_alert_filter_should_return_filter_description
930e94c
@Elise17
Added test_update_alert_filter_should_return_filter_type
120bed5
@Elise17
Added test_update_alert_filter_should_return_filter_data_alert_title
48c0957
@Elise17
Added test_update_alert_filter_should_return_404_when_alert_filter_is…
657d441 
…_not_found
@Elise17
Removed identifietr in test_update_alert_filter_should_return_404_whe…
1008f29 
…n_alert_filter_is_not_found
@Elise17
Deprecated endpoint POST /filters/update/{identifier}
78234ef
@Elise17
Started implmentation of endpoint DELETE /api/v2/alerts-filters/{iden…
eb541cb 
…tifier}
@Elise17
Added test_delete_alert_filter_should_return_404_when_alert_not_found
745739c
@Elise17
test_get_alert_filter_should_return_404_after_delete_alert_filter
74bf4ea
c8y3 added 21 commits November 21, 2025 11:52
@c8y3
Moved up an occurence of iris_current_user
6d720ff
@c8y3
Extracted methods
f570e27
@c8y3
No need for optional parameter
14b5814
@c8y3
Renamed method
ee34d5d
@c8y3
Use method from business
33d04dd
@c8y3
Moved up corner case in the business layer (does not require database…
7e99ab0 
… access)
@c8y3
Extracted method
b03ecd3
@c8y3
Extracted method
f99e77e
@c8y3
Moved code up into the business layer
e589c16
@c8y3
Code cleanup
22e0496
@c8y3
Flattened and_
3307565
@c8y3
Fixed ruff warning
e557cb7
@c8y3
Removed unused parameters
0f05312
@c8y3
Moved up iris_current_user
a9a91c2
@c8y3
Single quotes
4880f73
@c8y3
Extended existing import constraint
3fb4eda
@c8y3
Following calling conventions
055dc65
@c8y3
Moved up some imports to iris_current_user
e40674d
@c8y3
Added missing preamble
d3721f8
@c8y3
Moved up some imports to iris_current_user
043cac8
@c8y3
Enforced one more constraint to avoid importing iris_current_user fro…
0c1c654 
…m the persistence layer
@c8y3 c8y3 requested a review from whikernel November 21, 2025 16:40
@c8y3 c8y3 added the enhancement New feature or request label Nov 21, 2025
@c8y3 c8y3 linked an issue Nov 21, 2025 that may be closed by this pull request
API v2 get paginated global tasks #980
Open
15 tasks
@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch api_v2_paginated_global_tasks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whikernel whikernel Awaiting requested review from whikernel

Assignees

@whikernel whikernel

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API v2 get paginated global tasks

4 participants

@c8y3 @whikernel @Elise17