chore: Upgrade Rust version #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dragoljub-duric Clear communication is a very valuable skill to develop as an engineer - PR titles and descriptions are especially important components of that. Reading the current PR title/description, I see:
I'll approve but I'd encourage you to enhance the title/description and take that into account in future PRs. |
ielashi
approved these changes
Feb 12, 2024
dragoljub-duric
changed the title
dragoljub-duric
deleted the
EXC-1553-upgrade-rust-version-in-stable-structures-ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need rust >= 1.74 to use
div_ceil().Solution:
Upgrade the Rust version.