-
Notifications
You must be signed in to change notification settings - Fork 93
feat: Make integration #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vporton
wants to merge
481
commits into
dfinity:master
Choose a base branch
from
vporton:make-integration2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Make integration #4083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild-only-necessary
After fixing some bugs, I successfully deployed my site in production using my modified DFX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--no-compile
todeploy
andgenerate
and--no-deps
(don't compile dependencies) tobuild
.rules
that outputs GNU Make rules.Then rules can be used:
canister@NAME
- compile a canister.deploy@NAME
- deploy a canister.generate@NAME
- generate bindings for a canister.Implementation note: I added argument
no_deps
to many functions. This is a non-elegant code and I am asking you to advise me what can be done.I will be busy with another project. Maybe, somebody can maintain this my code meanwhile?
My proposal is to merge this PR ASAP, to ease maintaining. It contains experimental features, but probably won't disturb using other (non-experimental) features. However, some code was heavily changed.
How Has This Been Tested?
I ran tests for compiling my (temporarily closed source) repository.
I will inform you, when I will test it on open source software.
Checklist: