Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: sync .well-known dir by default #3759

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented May 15, 2024

Description

Well-founded complaint:

May I ask what's the reasoning between not allowing .well-known folder per default and forcing each developers to whitelist this folder in ic-assets.json?
I had to answer and explain countless time, often per private message, how to set up such a file. It's becoming annoying, particularly when I'm pinged late in the evening, therefore I am curious to know if there is a valid reason.

This PR automatically adds .well-known to the list of synced directories

Fixes SDK-1408

Inspired quite a bit by #2948

How Has This Been Tested?

Added unit tests

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested review from chenyan-dfinity and a team as code owners May 15, 2024 12:09
@sesi200 sesi200 changed the title fix!(frontend-canister): sync .well-known dir by default fix!: sync .well-known dir by default May 15, 2024
@ericswanson-dfinity ericswanson-dfinity merged commit d7265b1 into master May 15, 2024
179 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the SDK-1408-allow-wellknown-to-be-enabled-in-ic-assets-json-by-default branch May 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants