Add ingress messages reference #3535
Merged
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oggy-dfin
approved these changes
Sep 30, 2024
robin-kunzler
commented
Oct 9, 2024
There was a problem hiding this comment.
Thanks for the reviews and good input @jessiemongeon1 and @oggy-dfin !
Addressed everything, only have two clarifying questions to you Ogi!
roelstorms
reviewed
Oct 9, 2024
roelstorms
reviewed
Oct 9, 2024
roelstorms
reviewed
Oct 9, 2024
roelstorms
reviewed
Oct 9, 2024
roelstorms
reviewed
Oct 9, 2024
roelstorms
approved these changes
Oct 9, 2024
jessiemongeon1
approved these changes
Oct 9, 2024
yvonneanne
reviewed
Oct 9, 2024
yvonneanne
reviewed
Oct 9, 2024
|
Thanks for the additional feedback and input @roelstorms and @yvonneanne ! I addressed everything.
|
yvonneanne
reviewed
Nov 4, 2024
yvonneanne
reviewed
Nov 4, 2024
robin-kunzler
commented
Nov 5, 2024
There was a problem hiding this comment.
Good catches @yvonneanne , thanks. Addressed your comments, PTAL!
…ngress-messages-reference # Conflicts: # .github/CODEOWNERS # sidebars.js
yvonneanne
reviewed
Nov 5, 2024
yvonneanne
reviewed
Nov 5, 2024
yvonneanne
reviewed
Nov 5, 2024
robin-kunzler
commented
Nov 6, 2024
There was a problem hiding this comment.
@yvonneanne Thanks again for the additional input. Addressed the comments, could you PTAL?
yvonneanne
reviewed
Nov 6, 2024
yvonneanne
reviewed
Nov 6, 2024
yvonneanne
reviewed
Nov 6, 2024
robin-kunzler
commented
Nov 7, 2024
There was a problem hiding this comment.
Thanks for the review and additional feedback @yvonneanne . Addressed everything, PTAL!
yvonneanne
approved these changes
Nov 7, 2024
robin-kunzler
deleted the
robin-kunzler/add-ingress-messages-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reference document explaining ingress messaging.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdxfile format to support the previous two components./sidebars.js, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERSfile isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.