Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Logo button component #5388

Merged
merged 12 commits into from
Mar 24, 2025

Conversation

daviddecentage
Copy link
Collaborator

@daviddecentage daviddecentage commented Mar 21, 2025

Motivation

For the upcoming refactoring of several token lists, we create a super-generic logo button component that can be adjusted via props to fit all variants that we might need.

Changes

New component added

Tests

Title and titleEnd
image

With description
image

With description and descriptionEnd
image

Big logo
image

Selectable
image

No dividers
image

With subtitle
image

With toggle passed in action slot:
image

Example with badge and icons like a token card
image

@daviddecentage daviddecentage marked this pull request as ready for review March 21, 2025 16:36
@daviddecentage daviddecentage requested a review from a team as a code owner March 21, 2025 16:36
@daviddecentage daviddecentage marked this pull request as draft March 21, 2025 16:39
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the component NetworkLogo , can that one be changed/modified?

@daviddecentage
Copy link
Collaborator Author

daviddecentage commented Mar 21, 2025

We have the component NetworkLogo , can that one be changed/modified?

This component would also be used for the token cards/buttons, not just networks. Also, the goal is to replace the existing components and simplify the UI structure, since all UIs will then look the same and this component is highly configurable

@daviddecentage daviddecentage marked this pull request as ready for review March 21, 2025 18:12
Copy link
Contributor

@DenysKarmazynDFINITY DenysKarmazynDFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@daviddecentage daviddecentage enabled auto-merge (squash) March 24, 2025 09:05
@daviddecentage daviddecentage merged commit fda6d6a into main Mar 24, 2025
25 checks passed
@daviddecentage daviddecentage deleted the feat(frontend)/logo-button-component branch March 24, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants