-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Logo button component #5388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the component NetworkLogo
, can that one be changed/modified?
This component would also be used for the token cards/buttons, not just networks. Also, the goal is to replace the existing components and simplify the UI structure, since all UIs will then look the same and this component is highly configurable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Motivation
For the upcoming refactoring of several token lists, we create a super-generic logo button component that can be adjusted via props to fit all variants that we might need.
Changes
New component added
Tests
Title and titleEnd

With description

With description and descriptionEnd

Big logo

Selectable

No dividers

With subtitle

With toggle passed in action slot:

Example with badge and icons like a token card
