feat(frontend): reward canister services will use bigint instead of BigNumber #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-use-bigint-instead-of-BigNumber
DenysKarmazynDFINITY
approved these changes
Mar 24, 2025
…-use-bigint-instead-of-BigNumber
…-use-bigint-instead-of-BigNumber
…-use-bigint-instead-of-BigNumber
…-use-bigint-instead-of-BigNumber
AntonioVentilii
deleted the
feat(frontend)/reward-canister-services-will-use-bigint-instead-of-BigNumber
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to migrate to
ethersv6: one of the biggest change was the deprecation ofBigNumberin favour of built-inbigint(see documentation).To smooth the migration, we replace
BigNumberwithbigintin the services of the rewards canister.Changes
amountasbigintinstead ofBigNumber.Tests
Existing tests were sufficient.