Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): scroll sidebar to top #5369

Merged
merged 98 commits into from
Mar 24, 2025
Merged

Conversation

AntonioVentilii
Copy link
Collaborator

@AntonioVentilii AntonioVentilii commented Mar 20, 2025

Motivation

We try to fix the sidebar being scrolled by putting it back up.

Credits to @inc-man (PR #5378)

@AntonioVentilii AntonioVentilii added the run-e2e-snapshots It needs the CI for E2E Snapshots label Mar 20, 2025
@AntonioVentilii AntonioVentilii force-pushed the fix(e2e)/scroll-sidebar-to-top branch 2 times, most recently from 7217574 to 00b5d7e Compare March 21, 2025 13:55
@AntonioVentilii AntonioVentilii marked this pull request as ready for review March 24, 2025 07:57
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner March 24, 2025 07:57
Copy link
Collaborator

@inc-man inc-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tks

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) March 24, 2025 08:06
@AntonioVentilii AntonioVentilii merged commit 7953b49 into main Mar 24, 2025
28 of 30 checks passed
@AntonioVentilii AntonioVentilii deleted the fix(e2e)/scroll-sidebar-to-top branch March 24, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-snapshots It needs the CI for E2E Snapshots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants