Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Snapshot types #5351

Merged
merged 28 commits into from
Mar 24, 2025
Merged

feat(backend): Snapshot types #5351

merged 28 commits into from
Mar 24, 2025

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Mar 20, 2025

Motivation

The backend canister is to store account snapshots. This is to support a range of functionality, including fast loading and caching account identifiers.

Changes

  • Add account snapshot types.

Tests

Type implementations work

Unit tests are included, however there is very little functionality, hence few tests.

Types are backwards compatible with existing snapshots sent to the rewards canister

This is to avoid confusion

@bitdivine bitdivine marked this pull request as ready for review March 20, 2025 09:02
@bitdivine bitdivine requested a review from a team as a code owner March 20, 2025 09:02
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks! One small favour to ask:

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) March 21, 2025 08:33
@bitdivine bitdivine enabled auto-merge (squash) March 24, 2025 08:18
@bitdivine bitdivine merged commit 2eb6035 into main Mar 24, 2025
32 of 33 checks passed
@bitdivine bitdivine deleted the snapshot branch March 24, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants