-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): upgrade ethers to v6 #5314
Draft
AntonioVentilii
wants to merge
49
commits into
main
Choose a base branch
from
chore(build)/upgrade-ethers-to-v6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32041e9
to
4c8fd6e
Compare
899a617
to
6bc6b98
Compare
c1b5bbf
to
0be129c
Compare
4faade9
to
188001b
Compare
28e50cc
to
91ddce2
Compare
4d2e828
to
73c798b
Compare
a1bd3c1
to
c137e31
Compare
8d6c3bd
to
36647f7
Compare
3454c38
to
5cfb0be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are starting to include more EVM-based Layer-2 networks (for example Base). But before that we need to stay up-to-date with the latest
ethers
package (repo: https://github.com/ethers-io/ethers.js).Thankfully there is an easy guide to migrate from v5 to v6.
Note
Most of the changes are around the deprecation of
BigNumber
in favour of built-inbigint
.Changes
BigNumber
instances withbigint
.BigNumber
related operations (.add
,.gt
, etc) in favour of arithmetic ones.Tests
Current tests are sufficients.