refactor(devops): Specify ckUSDc ledger and index canister IDs in dfx.json #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make
dfx deploywork with sensible defaults for all canisters. This PR makes a step towards this for ckUSDC.Changes
--specified-idoverride that is no longer needed.Tests
e2e deployments work
Existing CI should suffice.
The local canister ID is correct
The
"specified_id":entries are identical to the values previously provided in flags.Remote canister IDs are correct
These are taken from here: https://github.com/dfinity/oisy-wallet/blob/main/src/frontend/src/env/tokens/tokens.ckerc20.json#L91