Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): ConvertAmountDisplay component #3533

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat(frontend): ConvertAmountDisplay component #3533

merged 1 commit into from
Nov 13, 2024

Conversation

DenysKarmazynDFINITY
Copy link
Contributor

Motivation

Desktop:

Screenshot 2024-11-13 at 17 09 57

Mobile:
Screenshot 2024-11-13 at 17 10 22

@DenysKarmazynDFINITY DenysKarmazynDFINITY requested a review from a team as a code owner November 13, 2024 16:11
peterpeterparker
peterpeterparker approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

PS: In you screenshots, it's written "Free". That's correct or it's a typo for "Fee"?

@DenysKarmazynDFINITY DenysKarmazynDFINITY force-pushed the feat(frontend)/convert-amount-display branch from fa61540 to 5d6554f Compare November 13, 2024 17:22
@DenysKarmazynDFINITY
Copy link
Contributor Author

@peterpeterparker it's actually "free", here is how the whole picture looks like (screenshot from figma):
Screenshot 2024-11-13 at 18 23 42

@DenysKarmazynDFINITY DenysKarmazynDFINITY merged commit bf806f6 into main Nov 13, 2024
14 checks passed
@DenysKarmazynDFINITY DenysKarmazynDFINITY deleted the feat(frontend)/convert-amount-display branch November 13, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenysKarmazynDFINITY @peterpeterparker