Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): added macos config #3496

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inc-man
Copy link
Collaborator

@inc-man inc-man commented Nov 13, 2024

Motivation

We also want to test against macOS devices.

Changes

  • add config to allow testing against macOS

Tests

tested on branch

@inc-man inc-man requested a review from a team as a code owner November 13, 2024 08:02
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested? I don't see any new screenshot in the branch

@inc-man
Copy link
Collaborator Author

inc-man commented Nov 13, 2024

for this to be available for testing I need all the other changes in first so we have macOS runners that work correctly

@AntonioVentilii
Copy link
Collaborator

@inc-man then we will put it in draft before merging, then await the rest and test it ok?

@AntonioVentilii AntonioVentilii marked this pull request as draft November 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants