Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor temp_keys in preparation for dynamic captcha registration flow (#2618)" #2632

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Revert "Refactor temp_keys in preparation for dynamic captcha registration flow (#2618)" #2632

merged 2 commits into from
Sep 27, 2024

Conversation

frederikrothenberger
Copy link
Contributor

@frederikrothenberger frederikrothenberger commented Sep 27, 2024 •
edited by github-actions bot
Loading

This reverts commit 60175a1.

The only changes kept from #2618 are two typo fixes in the comments. Reverting required to adapt the new flow module slightly.

Revert "Refactor temp_keys in preparation for dynamic captcha registr…
4dae1bf 
…ation flow (#2618)"

This reverts commit 60175a1.

The only changes kept from #2618 are two typo fixes in the comments.
Reverting required to adapt the new flow module slightly.
@frederikrothenberger frederikrothenberger requested a review from a team as a code owner September 27, 2024 09:44
lmuntaner
lmuntaner approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor comments, already approving.

src/internet_identity/src/state/temp_keys.rs Outdated Show resolved Hide resolved
src/internet_identity/src/state/temp_keys.rs Outdated Show resolved Hide resolved
@frederikrothenberger frederikrothenberger added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 6a6f616 Sep 27, 2024
66 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/revert-temp-key-enum branch September 27, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikrothenberger @lmuntaner