Add configuration options for upcoming dynamic captcha feature #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the required configuration options to make the captcha (on registration) dynamic: once implemented, if the dynamic config is enabled, the captcha will only be required on unusually high rate of new registrations.
lmuntaner
approved these changes
Sep 13, 2024
| @@ -21,7 +21,14 @@ fn should_retain_anchor_on_user_range_change() -> Result<(), CallError> { | |||
| time_per_token_ns: 99, | |||
| max_tokens: 874, | |||
| }), | |||
| max_inflight_captchas: Some(456), | |||
| captcha_config: Some(CaptchaConfig { | |||
| max_unsolved_captchas: 788, | |||
There was a problem hiding this comment.
Do the numbers mean anything? it was 456 before... I guess they don't, right?
There was a problem hiding this comment.
No, it's just different from the default, making sure that the values are not accidentally the same.
Thompson1985
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required configuration options to make the captcha
(on registration) dynamic: once implemented, if the dynamic config is
enabled, the captcha will only be required on unusually high rate of new
registrations.