Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New title "Choose Identity" when logging in #2486

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented May 31, 2024

Main motivation is to simplify the copy in certains screens as requested in https://dfinity.atlassian.net/browse/GIX-2526


🟡 Some screens were changed

@lmuntaner
Copy link
Collaborator Author

lmuntaner commented May 31, 2024

Changed screens:
Screenshot 2024-05-31 at 07 50 04
Screenshot 2024-05-31 at 07 50 12

I also changed the following screens to be consistent:

Screenshot 2024-05-31 at 09 53 01
Screenshot 2024-05-31 at 09 53 11

But I didn't change some other screens like the following because there is no "Iternet Identity" title.

Screenshot 2024-05-31 at 07 49 44
Screenshot 2024-05-31 at 07 51 26

@lmuntaner lmuntaner marked this pull request as ready for review May 31, 2024 07:56
@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger please review

Copy link
Contributor

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to use the 🔑 emoji?
(Sorry, I'm out of the loop regarding that decision).

@lmuntaner lmuntaner added this pull request to the merge queue Jun 3, 2024
@lmuntaner
Copy link
Collaborator Author

Do we really want to use the 🔑 emoji? (Sorry, I'm out of the loop regarding that decision).

Yes, that was a specific request.

Merged via the queue into main with commit 7816351 Jun 3, 2024
65 checks passed
@lmuntaner lmuntaner deleted the lm-change-choose-identity-title branch June 3, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants