Add PreLoadImage class to substitute IdentityBackground #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
commented
Apr 16, 2024
| import { dapps } from "../constants"; | ||
| import { displayManagePage } from "$src/flows/manage"; | ||
| import { html } from "lit-html"; | ||
| import identityCardBackground from "$src/assets/identityCardBackground.png"; |
There was a problem hiding this comment.
Importing it here we ensure that it doesn't get mixed with the application code and we don't need to cast types.
Ideally, we will move the showcase to its own library with its own package.json and then we will be able to separate import statements better.
lmuntaner
commented
Apr 16, 2024
|
|
||
| export const identityBackground = IdentityBackground.getSingleton( | ||
| // When running the build, this is also built but not in an Astro environment | ||
| (backgroundImage as unknown as ImageMetadata).src |
There was a problem hiding this comment.
The way to remove this ugly line was to import the asset in the .astro files directly.
|
@frederikrothenberger let me know what you think now. |
frederikrothenberger
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation is to remove the IdentityBackground class because it increases more the complexity than the value it adds.
The problem is that importing an asset in the showcase (Astro) and the application means different types of the imported value.
Before, we had a workaround that another instance of the class was created for the showcase and for the application.
IdentityBackground had two functionalities:
This PR introduces a new class
PreLoadImagethat has only the preloading functionality and expects an image as input.This allows us to use the image differently in Astro and app environments.