[FINAL] Adding an endpoint to fetch bitcoin block headers #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
reviewed
Apr 8, 2024
ielashi
reviewed
Apr 8, 2024
mraszyk
reviewed
Apr 11, 2024
ielashi
reviewed
Apr 12, 2024
dsarlis
approved these changes
Apr 12, 2024
Dfinity-Bjoern
approved these changes
Apr 16, 2024
Dfinity-Bjoern
changed the title
dragoljub-duric
added a commit
to dfinity/bitcoin-canister
that referenced
this pull request
May 21, 2024
As stated in [here](dfinity/interface-spec#298), candid interface should look as: ``` type bitcoin_block_header = blob; type get_block_headers_request = record { start_height : nat32; end_height: opt nat32; }; type get_block_headers_result = record { tip_height: nat32; block_headers: vec bitcoin_block_header; }; bitcoin_get_block_headers : (get_block_headers_request) -> (get_block_headers_response); ``` This PR will add no-op endpoint for returning the block headers in the [follow-up](#298) we will implement specified function.
dragoljub-duric
added a commit
to dfinity/bitcoin-canister
that referenced
this pull request
Jun 7, 2024
This PR implements `get_block_headers` endpoint as stated in dfinity/interface-spec#298. E2E test will be added in follow-up. Charging cycles, and determining the cost of the endpoint will be added in follow-up. --------- Co-authored-by: Islam El-Ashi <islam.elashi@dfinity.org>
dsarlis
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Bitcoin integration API does not expose any information about block headers.
This information would be useful to verify blocks (e.g., obtained using HTTPS outcalls) by comparing the Merkle root hash with the root hash in the block header.
This PR introduces a new endpoint
bitcoin_get_block_headers.The PR also reorganizes some Bitcoin integration related definitions to make things easier to read from top to bottom.