Skip to content

feat: expose inner certificate in Certificate #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

feat: expose inner certificate in Certificate #925

merged 1 commit into from
Sep 11, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Sep 11, 2024 •
edited
Loading

Description

Exposes the raw certificate from the Certificate class as Certificate.cert.

Partially fixes SDK-1828

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner September 11, 2024 16:50
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 85.96 KB (0%)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.36 KB (0%)
@dfinity/assets 80.98 KB (0%)
@dfinity/identity 57.56 KB (0%)
@dfinity/identity-secp256k1 131.14 KB (0%)

@krpeacock krpeacock merged commit 33f2e38 into main Sep 11, 2024
28 checks passed
@krpeacock krpeacock deleted the kai/expose-cert-inner branch September 11, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krpeacock @ericswanson-dfinity