Skip to content

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Nov 6, 2023

Description

For the sake of FOLLOW-1302, but also as a general utility, we can provide a class that implements a standard Map, but includes expiration times for all its entries. It will return undefined for any value that has gone stale

Fixes # (issue)

How Has This Been Tested?

new unit test coverage

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner November 6, 2023 21:30
Copy link
Contributor

github-actions bot commented Nov 6, 2023

size-limit report 📦

Path Size
@dfinity/agent 88.48 KB (0%)
@dfinity/candid 13.59 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.7 KB (0%)
@dfinity/assets 90.83 KB (0%)
@dfinity/identity 89.97 KB (0%)
@dfinity/identity-secp256k1 233.8 KB (0%)

@krpeacock krpeacock enabled auto-merge (squash) November 6, 2023 22:13
@ShuoWangNSL
Copy link

LGTM! It is great for the usage of cache of node keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants