Skip to content

chore: lock npm version for CI #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2023
Merged

chore: lock npm version for CI #762

merged 2 commits into from
Sep 6, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Sep 6, 2023 •
edited
Loading

Description

CI started failing after running npm i -g npm because version 10 is not compatible with node 16

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner September 6, 2023 18:06
@krpeacock krpeacock changed the title Kyle/lock npm version chore: lock npm version for CI Sep 6, 2023
@krpeacock krpeacock enabled auto-merge (squash) September 6, 2023 18:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

size-limit report 📦

Path Size
@dfinity/agent 87.17 KB (0%)
@dfinity/candid 13.52 KB (0%)
@dfinity/principal 5.15 KB (0%)
@dfinity/auth-client 92.54 KB (0%)
@dfinity/assets 89.7 KB (0%)
@dfinity/identity 89.81 KB (0%)
@dfinity/identity-secp256k1 232.27 KB (0%)

@krpeacock krpeacock merged commit 78e6e56 into main Sep 6, 2023
@krpeacock krpeacock deleted the kyle/lock-npm-version branch September 6, 2023 18:19
This was referenced Sep 6, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwshang lwshang lwshang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krpeacock @lwshang