Skip to content

fix(candid): recursive type table merging preserves concrete type mapping #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

fix(candid): recursive type table merging preserves concrete type mapping #1153

merged 3 commits into from
Sep 30, 2025
+77 −5

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Sep 26, 2025 •
edited
Loading

Description

Fixes demergent-labs/azle#1526.

How Has This Been Tested?

Added reproduction code as tests copied from the issue.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ilbertt ilbertt requested a review from a team as a code owner September 26, 2025 12:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 50.52 KB (+0.1% 🔺)
@dfinity/assets 55.49 KB (+0.04% 🔺)
@dfinity/auth-client 21.16 KB (0%)
@dfinity/candid 13.3 KB (-0.14% 🔽)
@icp-sdk/core 91 B (0%)
@dfinity/identity 20.61 KB (0%)
@dfinity/identity-secp256k1 33.88 KB (0%)
@dfinity/principal 4.44 KB (0%)

@lastmjs
Copy link
Contributor

lastmjs commented Sep 29, 2025

I can confirm that this PR resolves demergent-labs/azle#1526

@lastmjs lastmjs mentioned this pull request Sep 29, 2025
Closed
@ilbertt ilbertt merged commit 5bc5923 into main Sep 30, 2025
28 checks passed
@ilbertt ilbertt deleted the luca/fix-rec branch September 30, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwshang lwshang lwshang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problems with Rec Opt Nat8

3 participants

@ilbertt @lastmjs @lwshang