Skip to content

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Aug 23, 2025

Description

Only delete knot if it's the last entry of the TypeTable. This avoids removing shared knot types when multiple Rec()s are present in the same struct.

Fixes:

How Has This Been Tested?

Same tests should still pass.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Copy link
Contributor

github-actions bot commented Aug 23, 2025

size-limit report 📦

Path Size
@dfinity/agent 50.54 KB (+0.35% 🔺)
@dfinity/assets 55.45 KB (+0.12% 🔺)
@dfinity/auth-client 21.15 KB (0%)
@dfinity/candid 13.32 KB (+0.77% 🔺)
@icp-sdk/core 91 B (0%)
@dfinity/identity 20.59 KB (0%)
@dfinity/identity-secp256k1 33.88 KB (0%)
@dfinity/principal 4.44 KB (0%)

@ilbertt ilbertt changed the title fix: do not delete knot after merge fix: only delete knot if it's the last entry of the TypeTable Aug 23, 2025
@ilbertt ilbertt marked this pull request as ready for review August 23, 2025 17:36
@ilbertt ilbertt requested a review from a team as a code owner August 23, 2025 17:36
@ilbertt ilbertt marked this pull request as draft August 25, 2025 09:03
@ilbertt ilbertt marked this pull request as ready for review August 25, 2025 12:13
@ilbertt ilbertt merged commit 2dd918b into main Aug 26, 2025
31 of 40 checks passed
@ilbertt ilbertt deleted the luca/fix-typetable-merge branch August 26, 2025 12:21
@lastmjs
Copy link
Contributor

lastmjs commented Sep 26, 2025

FYI it looks like this PR did not fully resolve demergent-labs/azle#1526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants