Skip to content

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Aug 20, 2025

Description

Candid and cbor decoding can return bigints, so we must add that type to the return type.

Fixes demergent-labs/azle#2639.

How Has This Been Tested?

Same tests should pass.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ilbertt ilbertt requested a review from a team as a code owner August 20, 2025 17:40
Copy link
Contributor

github-actions bot commented Aug 20, 2025

size-limit report 📦

Path Size
@dfinity/agent 50.37 KB (0%)
@dfinity/assets 55.38 KB (0%)
@dfinity/auth-client 21.15 KB (0%)
@dfinity/candid 13.22 KB (0%)
@icp-sdk/core 91 B (0%)
@dfinity/identity 20.59 KB (0%)
@dfinity/identity-secp256k1 33.88 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 61.27 KB (0%)

@ilbertt ilbertt merged commit e23c0f5 into main Aug 20, 2025
28 checks passed
@ilbertt ilbertt deleted the luca/fix-candid-typing branch August 20, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonValue from @dfinity/candid does not support bigint (DFINITY)

2 participants