Skip to content

fix: enable certificate freshness checks for delegation certificates #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 6, 2025
Merged

fix: enable certificate freshness checks for delegation certificates #1094

merged 7 commits into from
Aug 6, 2025

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Aug 6, 2025

Description

Same as title

How Has This Been Tested?

Updated certificate unit tests.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ilbertt ilbertt requested a review from a team as a code owner August 6, 2025 09:50
@ilbertt ilbertt changed the title - fix: enable certificate freshness checks for delegation certificates fix: enable certificate freshness checks for delegation certificates Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 48.17 KB (-0.03% 🔽)
@dfinity/assets 53.21 KB (+0.19% 🔺)
@dfinity/auth-client 19.38 KB (0%)
@dfinity/candid 13.22 KB (0%)
@icp-sdk/core 91 B (0%)
@dfinity/identity 18.85 KB (0%)
@dfinity/identity-secp256k1 33.03 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 59.11 KB (+0.18% 🔺)

mraszyk
mraszyk approved these changes Aug 6, 2025
View reviewed changes
ilbertt and others added 2 commits August 6, 2025 12:06
@ilbertt @mraszyk
Update packages/agent/src/certificate.ts
0b933e9 
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
@ilbertt @mraszyk
Update packages/agent/src/certificate.ts
1e25144 
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
@ilbertt ilbertt merged commit a47a7f4 into main Aug 6, 2025
28 checks passed
@ilbertt ilbertt deleted the luca/SDK-2231-delegation-freshness-checks branch August 6, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraszyk mraszyk mraszyk approved these changes

+1 more reviewer

@nathanosdev nathanosdev nathanosdev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilbertt @nathanosdev @mraszyk