docs: copy 404.html to the root to make 404 work #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nathanosdev merged 1 commit into main from luca/docs-404

Jul 30, 2025

Member

ilbertt commented Jul 30, 2025

Description

Copy dist/core/404.html to dist/404.html to make Juno's 404 fallback work.

This will be unnecessary once we have a landing page for the root path.

How Has This Been Tested?

Same tests should still pass.

Checklist:

My changes follow the guidelines in CONTRIBUTING.md.
The title of this PR complies with Conventional Commits.
I have edited the CHANGELOG accordingly.
I have made corresponding changes to the documentation.


          docs: copy 404.html to the root to make 404 work

83d19f6

ilbertt requested a review from a team as a code owner

July 30, 2025 16:08

Contributor

github-actions bot commented Jul 30, 2025

size-limit report 📦

Path	Size
@dfinity/agent	47.91 KB (0%)
@dfinity/assets	52.94 KB (0%)
@dfinity/auth-client	19.38 KB (0%)
@dfinity/candid	13.22 KB (0%)
@icp-sdk/core	91 B (0%)
@dfinity/identity	18.81 KB (0%)
@dfinity/identity-secp256k1	33.03 KB (0%)
@dfinity/principal	4.44 KB (0%)
@dfinity/use-auth-client	58.77 KB (0%)

nathanosdev approved these changes

View reviewed changes

nathanosdev merged commit cc3563d into main

28 checks passed

nathanosdev deleted the luca/docs-404 branch

July 30, 2025 17:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet