Skip to content

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Jul 28, 2025

Description

Perform the canister range check unconditionally when verifying delegations.

How Has This Been Tested?

Same unit tests should still pass.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Copy link
Contributor

github-actions bot commented Jul 28, 2025

size-limit report 📦

Path Size
@dfinity/agent 47.92 KB (+0.04% 🔺)
@dfinity/assets 52.88 KB (-0.12% 🔽)
@dfinity/auth-client 19.38 KB (0%)
@dfinity/candid 13.22 KB (0%)
@icp-sdk/core 91 B (0%)
@dfinity/identity 18.81 KB (0%)
@dfinity/identity-secp256k1 33.03 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 58.78 KB (+0.03% 🔺)

@ilbertt ilbertt marked this pull request as ready for review August 4, 2025 08:22
@ilbertt ilbertt requested a review from a team as a code owner August 4, 2025 08:22
@ilbertt ilbertt merged commit 8b37687 into main Aug 4, 2025
28 checks passed
@ilbertt ilbertt deleted the luca/SDK-2202-canister-ranges-validation branch August 4, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants