fix: round ingress expiry before applying clock drift #1076
+158
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a consequence, adds the `addMilliseconds` method to the `Expiry` class
size-limit report 📦
|
nathanosdev
approved these changes
Jul 24, 2025
mraszyk
reviewed
Jul 24, 2025
nathanosdev
approved these changes
Jul 24, 2025
mraszyk
reviewed
Jul 24, 2025
mraszyk
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculates the ingress expiry by first rounding down the timeout and only then applying the clock drift.
As a consequence, adds the
deltaInMsAfterThresholdCheckoptional parameter toExpiry.fromDeltaInMillisecondsto allow for adding a delta after the internal threshold check.Blocked by #1075.
How Has This Been Tested?
Same tests should still pass. Added unit tests for
addMilliseconds.Checklist: