feat!: breaking out readState into signed and unsigned #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krpeacock
changed the title
ilbertt
reviewed
Apr 15, 2025
Co-authored-by: Luca Bertelli <luca.bertelli@dfinity.org>
nathanosdev
reviewed
Apr 23, 2025
packages/agent/src/polling/index.ts
Outdated
| function isSignedReadStateRequestWithExpiry( | ||
| value: unknown, | ||
| ): value is SignedReadStateRequestWithExpiry { | ||
| function isObjectWithProperty<O extends object, P extends string>( |
There was a problem hiding this comment.
This is much better now, thanks! I would just now rather move isObjectWithProperty and hasFunction outside the isSignedReadStateRequestWithExpiry function, especially because they are so generic and could be used elsewhere.
nathanosdev
approved these changes
Apr 23, 2025
4 tasks
Co-authored-by: Nathan Mc Grath <contact@nathanos.dev>
Co-authored-by: Luca Bertelli <luca.bertelli@dfinity.org>
* refactor: use new error system and error codes * test: update throw assertions to use the new error classes * feat: cbor error * test: assert error kind * test: fix e2e and mitm tests for certificate errors * test: remove console logs * fix: remove code and kind props from AgentErrorV2 * feat: der errors * feat: der error on public key * feat: hex decode error * feat: timeout errors * feat: polling errors * feat: canister status errors * feat: hash value errors * refactor: use error kind constructors * refactor: extend class instead of implementing abstract
krpeacock
commented
Apr 23, 2025
ilbertt
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
There are still some comments not resolved, so @krpeacock feel free to fix and/or resolve them.
Approving in the meantime.
krpeacock
added a commit
that referenced
this pull request
May 2, 2025
Co-authored-by: Luca Bertelli <luca.bertelli@dfinity.org> Co-authored-by: Nathan Mc Grath <contact@nathanos.dev>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to distinguish between requests which must be retried using the same payload and requests that can be reconstructed each time during polling, we have broken out the read state method into two separate "signed" and "unsigned" methods. This accommodates signatures made with a hardware wallet for, say, the nns dapp, but as a default, new signatures and Ingress experies will be calculated automatically during polling
This matches the strategies available in the rust agent.
Fixes # SDK-1992
How Has This Been Tested?
New unit and e2e tests.
Checklist: