feat: [MR-581] Add functionalities of creating and removing unverified checkpoint markers #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuoWangNSL
changed the title
adambratschikaye
approved these changes
Jul 30, 2024
ShuoWangNSL
force-pushed
the
shuo/unverified_marker
branch
from
5c8e0c8
to
3ea61cb
Compare
Co-authored-by: Stefan Schneider <31004026+schneiderstefan@users.noreply.github.com>
ShuoWangNSL
force-pushed
the
shuo/unverified_marker
branch
from
77ac8e5
to
95fba0c
Compare
schneiderstefan
approved these changes
Aug 6, 2024
…e_compute_manifest_request() should ccrash
ShuoWangNSL
force-pushed
the
shuo/unverified_marker
branch
from
0469189
to
d8538a9
Compare
pakhomov-dfinity
approved these changes
Aug 8, 2024
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…d checkpoint markers (dfinity#657) This PR adds a marker file whenever a tip or a state sync scratchpad is promoted to an official checkpoint. This marker file is only removed once the checkpoint has been successfully loaded. If the loading fails, the replica will crash, leaving the marker file within the checkpoint directory. Upon restarting, any checkpoints containing a marker file will be archived and ignored, preventing the system from entering a continuous crash loop due to repeatedly attempting to load a corrupt checkpoint. With the marker file, we don't need to load checkpoint the synced checkpoint twice at the end of state sync. Writing the marker file is limited to `CheckpointLayout` with `WritePolicy`. --------- Co-authored-by: Stefan Schneider <31004026+schneiderstefan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a marker file whenever a tip or a state sync scratchpad is promoted to an official checkpoint. This marker file is only removed once the checkpoint has been successfully loaded.
If the loading fails, the replica will crash, leaving the marker file within the checkpoint directory. Upon restarting, any checkpoints containing a marker file will be archived and ignored, preventing the system from entering a continuous crash loop due to repeatedly attempting to load a corrupt checkpoint.
With the marker file, we don't need to load checkpoint the synced checkpoint twice at the end of state sync.
Writing the marker file is limited to
CheckpointLayoutwithWritePolicy.