-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ic): Add Wasm target-features for canisters already enabled in runtime #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkkatesh-sekar
changed the title
chore(ic, canisters): Add Wasm target-features already enabled in runtime
chore(ic,canisters): Add Wasm target-features already enabled in runtime
Jul 26, 2024
venkkatesh-sekar
changed the title
chore(ic,canisters): Add Wasm target-features already enabled in runtime
chore(ic): Add Wasm target-features for canisters already enabled in runtime
Jul 26, 2024
This reverts commit f70f266.
nmattia
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp
frankdavid
pushed a commit
that referenced
this pull request
Sep 25, 2024
…runtime (#631) `bulk-memory` is marked as `Stable` in [rustc](https://github.com/rust-lang/rust/blob/48bbe123c25936848f5ca910ae64a9ccb2b5159d/compiler/rustc_target/src/target_features.rs#L327)
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…runtime (dfinity#631) `bulk-memory` is marked as `Stable` in [rustc](https://github.com/rust-lang/rust/blob/48bbe123c25936848f5ca910ae64a9ccb2b5159d/compiler/rustc_target/src/target_features.rs#L327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulk-memory
is marked asStable
in rustc