Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove reexport in PocketIC library #2557

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 11, 2024

This PR removes the reexport pocket_ic::CanisterSettings in the PocketIC library: use pocket_ic::management_canister::CanisterSettings instead.

This reverts commit c4616f0.
@mraszyk mraszyk requested review from a team as code owners November 11, 2024 18:30
@github-actions github-actions bot added the chore label Nov 11, 2024
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraszyk mraszyk added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit bcbccf7 Nov 12, 2024
28 checks passed
@mraszyk mraszyk deleted the mraszyk/pic-reexport branch November 12, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants