Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crypto): CRP-2597 Extend NiDkgTag with HighThresholdForKey variant #2445

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

feat(crypto): CRP-2597 Extend NiDkgTag with HighThresholdForKey variant #2445

wants to merge 54 commits into from

Commits on Oct 31, 2024

  1. feat(crypto): CRP-2597 make NiDkgTag non-Copy

    @fspreiss
    fspreiss committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a4e5d35 View commit details
    Browse the repository at this point in the history

  2. More fixes

    @fspreiss
    fspreiss committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    808aa1d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Take NiDkgId as ref in combine_threshold_sig_shares

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9cb80e8 View commit details
    Browse the repository at this point in the history

  2. Take NiDkgId as ref in verify_threshold_sig_combined

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4461616 View commit details
    Browse the repository at this point in the history

  3. Take NiDkgId as ref at more places

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0ae9cdc View commit details
    Browse the repository at this point in the history

  4. Fmt

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3a8675b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-make-… 

    …nidkgtag-non-copy
    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8c447fd View commit details
    Browse the repository at this point in the history

  6. Remove unused dkg_id param of NiDkgCspClient::load_threshold_signing_key

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5e466de View commit details
    Browse the repository at this point in the history

  7. Cleanup benches

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b5343d6 View commit details
    Browse the repository at this point in the history

  8. NiDkgConfig::dkg_id now returns ref

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    64a7b7b View commit details
    Browse the repository at this point in the history

  9. Remove obsolete dkg_id param in NiDkgCspClient::create_dealing

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e0e60b9 View commit details
    Browse the repository at this point in the history

  10. Remove obsolete dkg_id param in NiDkgCspClient::verify_dealing

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    26e2b6a View commit details
    Browse the repository at this point in the history

  11. Remove obsolete dkg_id param in NiDkgCspClient::verify_resharing_dealing

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    14fec1d View commit details
    Browse the repository at this point in the history

  12. Cleanup

    @fspreiss
    fspreiss committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7339b90 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. refactor(crypto): CRP-2597 move MasterPublicKeyId protobuf from regis… 

    …try/crypto to types
    @fspreiss
    fspreiss committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    51c18be View commit details
    Browse the repository at this point in the history

  2. Clippy et al

    @fspreiss
    fspreiss committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d3a5dc8 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-make-… 

    …nidkgtag-non-copy
    @fspreiss
    fspreiss committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7fda226 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'franzstefan/CRP-2597-make-nidkgtag-non-copy' into franz… 

    …stefan/CRP-2597-move-masterpublickeyid-proto-to-types-ontopof-non-copy-ni-dkg-id
    @fspreiss
    fspreiss committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e98b7d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. feat(crypto): CRP-2597-extend-nidkg-tag-with-high-threshold-for-keyid… 

    …-variant
    @fspreiss
    fspreiss committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    dbaf13a View commit details
    Browse the repository at this point in the history

  2. Fix deps

    @fspreiss
    fspreiss committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c51dc23 View commit details
    Browse the repository at this point in the history

  3. Remove obsolete conversion i32->NiDkgTag

    @fspreiss
    fspreiss committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fce1c63 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-move-… 

    …masterpublickeyid-proto-to-types
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d3c49ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'franzstefan/CRP-2597-move-masterpublickeyid-proto-to-types 

    ' into franzstefan/CRP-2597-extend-nidkg-tag-with-keyid-variant
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ac819a5 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-move-… 

    …masterpublickeyid-proto-to-types
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d43b4eb View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-move-… 

    …masterpublickeyid-proto-to-types
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e003679 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'franzstefan/CRP-2597-move-masterpublickeyid-proto-to-types 

    ' into franzstefan/CRP-2597-extend-nidkg-tag-with-keyid-variant
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    06f027f View commit details
    Browse the repository at this point in the history

  6. Cleanup

    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6a5a578 View commit details
    Browse the repository at this point in the history

  7. Tests

    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    07fb339 View commit details
    Browse the repository at this point in the history

  8. Do not benchmark NiDkgTag::HighThresholdForKey for now

    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0c1c7a7 View commit details
    Browse the repository at this point in the history

  9. Do not support new tag in new_with_inverted_threshold

    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b17d8f9 View commit details
    Browse the repository at this point in the history

  10. Add test should_return_error_if_ni_dkg_tag_invalid_with_invalid_maste… 

    …r_public_key_when_parsing_proto
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ac37697 View commit details
    Browse the repository at this point in the history

  11. Extend TODO description

    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7cfe2f7 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-move-… 

    …masterpublickeyid-proto-to-types
    @fspreiss
    fspreiss committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c610e98 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add comment

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    14cfb31 View commit details
    Browse the repository at this point in the history

  2. Store: rename capacity and improve docu

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4fadc02 View commit details
    Browse the repository at this point in the history

  3. Typo in docu

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3ad52e4 View commit details
    Browse the repository at this point in the history

  4. Typo

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    770c4e4 View commit details
    Browse the repository at this point in the history

  5. Custom ExhaustiveSet impl for NiDkgTag

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    cd99051 View commit details
    Browse the repository at this point in the history

  6. Rename to high_threshold_for_key_dkg_id_insertion_order

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    df71d3a View commit details
    Browse the repository at this point in the history

  7. Fix store invariant

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    caccc55 View commit details
    Browse the repository at this point in the history

  8. Update ThresholdSigDataStore tests

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4d167a8 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'franzstefan/CRP-2597-move-masterpublickeyid-proto-to-types 

    ' into franzstefan/CRP-2597-extend-nidkg-tag-with-keyid-variant
    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    348d4a0 View commit details
    Browse the repository at this point in the history

  10. Link to CON-1416 in generate_responses_to_setup_initial_dkg_calls

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    61cc0d7 View commit details
    Browse the repository at this point in the history

  11. Link to CON-1413 in get_configs_for_local_transcripts and combine pat… 

    …terns
    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ae903fb View commit details
    Browse the repository at this point in the history

  12. Link to CON-1417 in test_make_genesis_summary

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dece589 View commit details
    Browse the repository at this point in the history

  13. Link to CON-1413 in test_create_regular_summaries

    @fspreiss
    fspreiss committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    88f4281 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Remove TODO on deciding about TaggedNiDkgTranscript serialization

    @fspreiss
    fspreiss committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6f9dd2a View commit details
    Browse the repository at this point in the history

  2. Remove TODO for testing build_tagged_transcripts_map

    @fspreiss
    fspreiss committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d9c19c3 View commit details
    Browse the repository at this point in the history

  3. Add TODO to remove result_large_err clippy exception

    @fspreiss
    fspreiss committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2f3ad02 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge remote-tracking branch 'origin' into franzstefan/CRP-2597-exten… 

    …d-nidkg-tag-with-keyid-variant
    @fspreiss
    fspreiss committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    dac4059 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. CAPACITY_PER_TAG -> CAPACITY_PER_TAG_OR_KEY

    @fspreiss
    fspreiss committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    29e2eb8 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Fail if NiDkgId::key_id is Some for Low/HighThreshold tags

    @fspreiss
    fspreiss committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b5eb7bd View commit details
    Browse the repository at this point in the history

  2. Fail if TaggedNiDkgTranscript::key_id is Some for Low/HighThreshold tags

    @fspreiss
    fspreiss committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ad29f17 View commit details
    Browse the repository at this point in the history

  3. panic! -> todo!("CON-XYZ")

    @fspreiss
    fspreiss committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    964dbb5 View commit details
    Browse the repository at this point in the history