chore(ICP-Rosetta): FI-1479: fix search transactions endpoint #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbjorkqvist
reviewed
Sep 24, 2024
rs/rosetta-api/tests/system_tests/test_cases/search_transactions.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
…ns.rs Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
mbjorkqvist
approved these changes
Sep 24, 2024
rs/rosetta-api/tests/system_tests/test_cases/search_transactions.rs
Outdated
Show resolved
Hide resolved
rs/rosetta-api/tests/system_tests/test_cases/search_transactions.rs
Outdated
Show resolved
Hide resolved
|
Thanks, @NikolasHai ! |
frankdavid
pushed a commit
that referenced
this pull request
Sep 25, 2024
This MR proposes the following changes: 1. Delete the existing implementation of search transactions 2. Add an implementation of search transactions that matches the standard and the icrc1 rosetta implementation 3. Add tests for all search options --------- Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…y#1585) This MR proposes the following changes: 1. Delete the existing implementation of search transactions 2. Add an implementation of search transactions that matches the standard and the icrc1 rosetta implementation 3. Add tests for all search options --------- Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR proposes the following changes: