chore(PocketIC): route requests to /_/ in PocketIC HTTP gateway #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weigelt
approved these changes
Sep 23, 2024
frankdavid
pushed a commit
that referenced
this pull request
Sep 25, 2024
The PocketIC HTTP gateway routes requests whose paths start with `/_/` and for which no canister ID can be found directly to the PocketIC instance/replica (this only used to apply to requests for `/_/dashboard` independently of whether a canister ID could be found). This way, the PocketIC HTTP gateway could be used to browse all "hidden" replica paths in local development without talking to the replica directly (which requires distributing two URLs to the client - one for the gateway and another one for the replica).
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…ity#1574) The PocketIC HTTP gateway routes requests whose paths start with `/_/` and for which no canister ID can be found directly to the PocketIC instance/replica (this only used to apply to requests for `/_/dashboard` independently of whether a canister ID could be found). This way, the PocketIC HTTP gateway could be used to browse all "hidden" replica paths in local development without talking to the replica directly (which requires distributing two URLs to the client - one for the gateway and another one for the replica).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PocketIC HTTP gateway routes requests whose paths start with
/_/and for which no canister ID can be found directly to the PocketIC instance/replica (this only used to apply to requests for/_/dashboardindependently of whether a canister ID could be found). This way, the PocketIC HTTP gateway could be used to browse all "hidden" replica paths in local development without talking to the replica directly (which requires distributing two URLs to the client - one for the gateway and another one for the replica).