Improve stakeNeuron test coverage #743
Merged
+62
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mstrasinskis
approved these changes
Oct 30, 2024
1 task
dskloetd
added a commit
that referenced
this pull request
Nov 1, 2024
# Motivation We want to be able to claim a neuron from NNS dapp if the stake process was interrupted after the transfer but before the claim. For this we need to be able to calculate the neuron account identifier to confirm that a transaction was made for the purpose of staking. So we would like to reuse the code that calculates the account identifier of the neuron from a memo. # Changes Extract the code to calculate a neuron account identifier from `packages/nns/src/governance.canister.ts` and export it from `packages/nns/src/utils/neurons.utils.ts`. # Tests 1. Added some "change detector" unit tests. 2. The original code is covered by test coverage added in #743 # Todos - [x] Add entry to changelog (if necessary). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to refactor the memo to neuron (sub)account calculation to make it available to clients.
But currently the calculated account identifier is not tested.
So before I start changing that code I want to make sure it's tested.
Changes
transferandmanage_neuron.Tests
PR is test-only. Tests pass.
Todos
not necessary