Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose icrc ledger.converters #724

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

peterpeterparker
Copy link
Member

Motivation

Similarly to #716 for ICP, we also need to exposes the ICRC ledger.converters for the signer standards library.

Changes

  • Expose module in index.ts

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Copy link
Contributor

github-actions bot commented Sep 30, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.99 KB (0%)
@dfinity/cketh 3.53 KB (0%)
@dfinity/cmc 1.3 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.25 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.87 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 3.01 KB (0%)

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tks

@peterpeterparker peterpeterparker merged commit 6187a69 into main Sep 30, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/expose-converters branch September 30, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants