Add support for "Regtest" BTC network #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
@dskloetd @peterpeterparker please review |
Which docs? IGNORE, I found it. |
lmuntaner
added a commit
to dfinity/oisy-wallet
that referenced
this pull request
Sep 9, 2024
# Motivation I want to use `"regtest"` from `BitcoinNetwork` type. The new entry was added in dfinity/ic-js#713 and it hasn't been published in any version but next yet. # Changes * Upgrade ckbtc to `3.0.0-next-2024-09-09` # Tests I checked that the new entry is accessible in node_modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use Regtest for local development in Oisy, but at the moment, this network is not supported in the
BitcoinNetwork.Changes
"regtest"as supported BitcoinNetwork and change the mapper to support the new value.Tests
No new functionality.
Todos