feat: icrc21_canister_call_consent_message for ledger-icrc #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
size-limit report 📦
|
peterpeterparker
added a commit
that referenced
this pull request
Sep 3, 2024
# Motivation Add similar doc for Icrc consent message request objects for ICP as for ICRC provided in PR #710. Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
peterpeterparker
added a commit
that referenced
this pull request
Sep 4, 2024
# Motivation The `@dfinity/ledger-icrc` gained weight (just a bit) in #710. Given that we are really precaucious, it makes the test fails. # Changes - Add 1kb to the limit (5 instead of 4) Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for
icrc21_canister_call_consent_messageto@dfinity/ledger-icrc.Notes
It annoys me a bit that the close basically duplicates the code of ICP (provided in PR #709) but, not sure it is worth the effort at this point to create a util or even lib for that particular topic. We might do so if more canisters starts implementing consent message but, happy to hear any thoughts about it.
Changes
consentMessage.